We're updating the issue view to help you get more done. 

Boni from equipment is not correctly removed from build-in weapons

Description

Example:
vision_magnification in helmet grants +2 on the 3 right distance categories. Whenever this is removed and reinstalled, +2 is added to build in weapons (e.g. yamaha_raiden_launcher), summing up to far too high values. It seems that when removing the modification, the +2 is not removed from build-in weapons.
Note: This works correctly for the main weapon (e.g. yamaha_raiden assault rifle itself)

Note1:
vision_magnification ist the only item which uses <attrmod, while all other modifications use <itemattrmod. Can this be relevant?

  • vision_magnification : <attrmod attr="ATTACK_RATING" ar="0,0,2,2,2"/>

  • example: foregrip : <itemattrmod attr="ATTACK_RATING" objVal="+1,+2,+1,," />

Note 2:
Yamaha raiden launcher and shotgun are added with <accessorymod> to the weapon. Whenusing <itemmod> the error does not seem to exist. Due to <accessorymod> the underbarrel weapons do not show up in the weapon list, maybe this is the reason why they are not considered when removing th +2 from vision_magnification.

Environment

None

Assignee

Unassigned

Reporter

Robert

Labels

None

Priority

Medium
Configure